Deprecte Rounding#round (backport #57845) #57893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates
Rounding#round
andRounding#nextRoundingValue
infavor of calling
because it is always going to be faster to prepare once. There
are going to be some cases where we won't know what to prepare for
and in those cases you can call
prepareForUnknown
and stil be fasterthan calling the deprecated method over and over and over again.
Ultimately, this is important because it doesn't look like there is an
easy way to cache
Rounding.Prepared
or any of its precursors likeLocalTimeOffset.Lookup
. Instead, we can just build it at most once perrequest.
Relates to #56124